New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js 11 not supported #1063

Closed
kibertoad opened this Issue Oct 23, 2018 · 13 comments

Comments

Projects
None yet
9 participants
@kibertoad

kibertoad commented Oct 23, 2018

There are no prebuilt node-sqlite3 binaries for Node.js 11, and when Travis attempts to build them instead, this error is thrown:

make: *** [Release/obj.target/sqlite3/gen/sqlite-autoconf-3240000/sqlite3.o] Error 1
make: Leaving directory `/home/travis/build/tgriesser/knex/node_modules/sqlite3/build'
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/home/travis/.nvm/versions/node/v11.0.0/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack     at ChildProcess.emit (events.js:182:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:240:12)
gyp ERR! System Linux 4.4.0-101-generic
gyp ERR! command "/home/travis/.nvm/versions/node/v11.0.0/bin/node" "/home/travis/.nvm/versions/node/v11.0.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "build" "--fallback-to-build" "--module=/home/travis/build/tgriesser/knex/node_modules/sqlite3/lib/binding/node-v67-linux-x64/node_sqlite3.node" "--module_name=node_sqlite3" "--module_path=/home/travis/build/tgriesser/knex/node_modules/sqlite3/lib/binding/node-v67-linux-x64" "--napi_version=3" "--node_abi_napi=napi"
gyp ERR! cwd /home/travis/build/tgriesser/knex/node_modules/sqlite3
gyp ERR! node -v v11.0.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok 
node-pre-gyp ERR! build error 
node-pre-gyp ERR! stack Error: Failed to execute '/home/travis/.nvm/versions/node/v11.0.0/bin/node /home/travis/.nvm/versions/node/v11.0.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js build --fallback-to-build --module=/home/travis/build/tgriesser/knex/node_modules/sqlite3/lib/binding/node-v67-linux-x64/node_sqlite3.node --module_name=node_sqlite3 --module_path=/home/travis/build/tgriesser/knex/node_modules/sqlite3/lib/binding/node-v67-linux-x64 --napi_version=3 --node_abi_napi=napi' (1)
node-pre-gyp ERR! stack     at ChildProcess.<anonymous> (/home/travis/build/tgriesser/knex/node_modules/node-pre-gyp/lib/util/compile.js:83:29)
node-pre-gyp ERR! stack     at ChildProcess.emit (events.js:182:13)
node-pre-gyp ERR! stack     at maybeClose (internal/child_process.js:962:16)
node-pre-gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:251:5)
node-pre-gyp ERR! System Linux 4.4.0-101-generic
node-pre-gyp ERR! command "/home/travis/.nvm/versions/node/v11.0.0/bin/node" "/home/travis/build/tgriesser/knex/node_modules/.bin/node-pre-gyp" "install" "--fallback-to-build"
node-pre-gyp ERR! cwd /home/travis/build/tgriesser/knex/node_modules/sqlite3
node-pre-gyp ERR! node -v v11.0.0
node-pre-gyp ERR! node-pre-gyp -v v0.10.3
node-pre-gyp ERR! not ok 
Failed to execute '/home/travis/.nvm/versions/node/v11.0.0/bin/node /home/travis/.nvm/versions/node/v11.0.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js build --fallback-to-build --module=/home/travis/build/tgriesser/knex/node_modules/sqlite3/lib/binding/node-v67-linux-x64/node_sqlite3.node --module_name=node_sqlite3 --module_path=/home/travis/build/tgriesser/knex/node_modules/sqlite3/lib/binding/node-v67-linux-x64 --napi_version=3 --node_abi_napi=napi' (1)
@mserajnik

This comment has been minimized.

mserajnik commented Oct 24, 2018

Can confirm that the build also fails for me under macOS 10.14 / Node.js 11.0.

@deltaskelta

This comment has been minimized.

deltaskelta commented Oct 26, 2018

Can anyone see what the problem is here? I can't quite make out what is going on

@cspencer0101

This comment has been minimized.

cspencer0101 commented Oct 26, 2018

Are there plans to convert this project to using N-API? It seems that issues such as this would be avoided in the future by using N-API.

I'd love to start using Node 11, but my project requires sqlite3, so I'm stuck with Node 10.x until the install gets fixed up.

@kewde

This comment has been minimized.

Collaborator

kewde commented Oct 30, 2018

#1072

@panther7

This comment has been minimized.

panther7 commented Nov 2, 2018

Hi,
we are need this ASAP, because we using latest nwjs with nodejs11.
Thank you very much ;-)

@kibertoad

This comment has been minimized.

kibertoad commented Nov 2, 2018

@panther7 Fix is ready - #1072, I think the only reason why it wasn't merged yet is that Appveyor is lagging behind and doesn't support node 11 yet. You can either go bug them or convince maintainers to merge appveyor change separately :)

@panther7

This comment has been minimized.

panther7 commented Nov 2, 2018

@kibertoad incredibly :D

@magneticchen

This comment has been minimized.

magneticchen commented Nov 5, 2018

macOS 10.14 / Node.js 11.0 failed confirmed.

@panther7

This comment has been minimized.

panther7 commented Nov 6, 2018

+1

1 similar comment
@BackPacker777

This comment has been minimized.

BackPacker777 commented Nov 7, 2018

+1

@kewde

This comment has been minimized.

Collaborator

kewde commented Nov 9, 2018

I'll merge it this weekend, hopefully appveyor supports it as we rely on them to create the builds used in production.

@fionaabbott

This comment has been minimized.

fionaabbott commented Nov 9, 2018

I've been getting this same error on Node.js 10.13.0, what would you suggest?

@kewde

This comment has been minimized.

Collaborator

kewde commented Nov 9, 2018

NodeJS 11 support has been added and the prebuilt packages should be available in a couple of hours, depending on the CI.

You can track the latest commit here:
https://github.com/mapbox/node-sqlite3/commits/master

@kewde kewde closed this Nov 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment