Pansharp window #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @celoyd |
8 tasks
Option to output 16bit tifs
|
This PR implements:
@dnomadb mind 👀 before we merge into master? Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "half-window" approach assumes the panchromatic band was exactly half the resolution but otherwise aligned. The geotransform of B8 indicates that the pan band is off by 7.5 meters from the color bands - the assumption might be the source of shifting/"embossing" issues?
This PR, instead of assuming a half window, takes a more flexible approach by using rasterio's internal logic for determining windows, bounds and affine transforms. It also adds some padding in case any interpolation needs to happen around the edges.
This is a "works for me" PR, @celoyd can I get your help testing on some of your known problem cases?
resolves #1