Only unbox NSNumbers 0, 1 to Bool for objCType 'c' #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Previously, initializing JSONValue with NSNumber with value 0 or 1 would produce JSONValue.boolean. This change updates the behavior to only interpret NSNumber as boolean if its objCType is 'c' and its value is 0 or 1.
macdrevx
force-pushed
the
fix-nsnumber-unboxing
branch
from
f16aa11
to
98f3e90
Compare
macdrevx
commented
Feb 25, 2022
Comment on lines
+11
to
+12
| XCTAssertEqual(JSONValue(rawValue: false), .boolean(false)) | ||
| XCTAssertEqual(JSONValue(rawValue: true), .boolean(true)) |
There was a problem hiding this comment.
Not sure whether supporting passing unboxed Bool was intentional @1ec5, but the old implementation did allow it, so I kept the behavior and added tests to verify it.
1ec5
approved these changes
Feb 25, 2022
There was a problem hiding this comment.
Thanks, your solution demonstrates what I had been missing in #173 (comment).
| /// In practice, choosing .boolean yields the desired result more often since it is more | ||
| /// common to work with Bool than it is Int8. | ||
| switch String(cString: number.objCType) { | ||
| case "c": // char |
There was a problem hiding this comment.
This is consistent with mapbox/mapbox-gl-native#6049 (comment). so I’m confident in this fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, initializing
JSONValuewithNSNumberwith value 0 or 1 would produceJSONValue.boolean. This change updates the behavior to only interpretNSNumberas boolean if itsobjCTypeis'c'and its value is 0 or 1.