Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When creating a new stamp based on tile selection, only the current layer is captured #2899

Closed
bjorn opened this issue Sep 28, 2020 · 3 comments
Closed

When creating a new stamp based on tile selection, only the current layer is captured #2899

bjorn opened this issue Sep 28, 2020 · 3 comments
Assignees
@bjorn
Labels
bug Broken behavior. usability Generally about making something more intuitive or efficient.

Comments

@bjorn
Copy link
Member

bjorn commented Sep 28, 2020

It should capture all selected layers.

As seen on phanxgames' stream.
@bjorn bjorn added the usability Generally about making something more intuitive or efficient. label Sep 28, 2020
@seanmorris
Copy link

I'm seeing this issue too. Spent an hour checking the docs to see if I was doing something wrong.

@seanmorris
Copy link

I would have labeled this a bug, since the docs say:

Ctrl + 1-9 - Store current tile stamp (similar to Ctrl + C)

@bjorn bjorn added the bug Broken behavior. label Aug 3, 2021
@bjorn bjorn self-assigned this Aug 10, 2021
@bjorn bjorn closed this as completed in d082031 Aug 10, 2021
bjorn added a commit that referenced this issue Aug 10, 2021
@bjorn
docs: Small clarification about creating tile stamps
c38e9be 
See issue #2899
@bjorn
Copy link
Member Author

bjorn commented Aug 10, 2021

I would have labeled this a bug

I can imagine it feels more like a bug, though from a programmer's perspective it was a missing feature. The code in question dated back to Tiled 0.13 and older, but multi-layer selection has only been supported since Tiled 1.2. But now it's finally updated! :-)

I've clarified the documentation a little.

bjorn added a commit that referenced this issue Aug 10, 2021
@bjorn
Fixed creating multi-layer tile stamp from selection
fe93bbe 
When creating a tile stamp from the selection rather than saving the
currently active stamp, only the "current layer" was being captured.
Since we can now selected multiple layers, this code still needed to be
adjusted to create the stamp based on all selected tile layers.

Closes #2899

(cherry picked from commit d082031)
bjorn added a commit that referenced this issue Aug 10, 2021
@bjorn
docs: Small clarification about creating tile stamps
0a23524 
See issue #2899

(cherry picked from commit c38e9be)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bjorn bjorn

Labels
bug Broken behavior. usability Generally about making something more intuitive or efficient.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bjorn @seanmorris