World Tool: Adding Map often end up offsetted

[meniku]

On a map that isn't part of a loaded world: When using the World Tool to add it to an opened world, it might end up in slightly offset positions, so it doesn't properly fit into the grid ( see screenshot below )

I did not encounter that issue when using the "Add another map" action. So it's not a big deal, but maybe the other action should be disabled or fixed

[bjorn]

Hmm, the various actions work differently as follows:

• The "Add another map to the current world" tool bar action positions the map such that its origin is in the center of the map view.
• The "Add a Map to World ..." context menu action positions the map with its origin at the clicked location.
• The "Add to " tool bar and context menu actions position the map with its origin in the top-right of the last map added to the world.

It appears the last action is not working for you as expected. Could you provide some more details, or possibly upload some files so I could reproduce this problem? Asking because it's working fine in my tests.

[meniku]

sample.zip

[bjorn]

Turns out this was an off-by-one on the X axis since QRect::topRight is, for historical reasons, not exactly where you'd expect:

I just hadn't noticed is while testing.

Another issue stems from the fact that all move operations on the map appear to be rounding the offset to whole tiles, but if the original position of a map is not aligned to the grid, this makes it essentially impossible to put it at an aligned position. I think I should change it to snap the target position instead.

Edit: Actually, when moving with the arrow keys the target position is snapped. It's only when dragging a world with the mouse, that the offset is snapped instead.

[bjorn]

Thanks for bringing this up! The fix will be available in the next development snapshot and the Tiled 1.5 release.

To work around the issue in Tiled 1.4, move your maps with the arrow keys to ensure they are each aligned to the grid.