Display full path in recent files menu #1992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch! But let's use http://doc.qt.io/qt-5/qmenu.html#toolTipsVisible-prop, and set the full path on the tool tip, to avoid the menu becoming very wide in some cases. Usually it's not very common to have many times the same file name.
|
|
Thanks for reviewing, |
bjorn
reviewed
Sep 10, 2018
src/tiled/mainwindow.cpp
Outdated
| @@ -1328,6 +1329,7 @@ void MainWindow::updateRecentFilesMenu() | |||
| mRecentFiles[i]->setText(QFileInfo(files[i]).fileName()); | |||
| mRecentFiles[i]->setData(files[i]); | |||
| mRecentFiles[i]->setVisible(true); | |||
| mRecentFiles[i]->setToolTip(QFileInfo(files[i]).filePath()); | |||
There was a problem hiding this comment.
Just a small suggestion: please re-use the QFileInfo instance. Not that the code is performance-critical, but in general it's good to avoid duplicating work.
There was a problem hiding this comment.
Sure, I just updated
* Coding style places & or * against the variable name * Generally only using auto when it reduces code size
|
Nice addition, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful when different files have the same name