Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add objectgroup rendering to tmxrasterizer #2187

Merged
merged 2 commits into from
Sep 4, 2019
Merged

add objectgroup rendering to tmxrasterizer #2187

merged 2 commits into from
Sep 4, 2019

Conversation

oncer
Copy link
Contributor

@oncer oncer commented Aug 22, 2019

also do not abort rendering if not all tmx files inside a world can be loaded

add objectgroup rendering to tmxrasterizer
577fdb1 
also do not abort rendering if not all tmx files inside a world can be loaded
bjorn
bjorn requested changes Aug 23, 2019
View reviewed changes
Copy link
Member

@bjorn bjorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks fine, I just added two requests, thanks!

src/tmxrasterizer/tmxrasterizer.cpp Outdated Show resolved Hide resolved
src/tmxrasterizer/tmxrasterizer.cpp Outdated Show resolved Hide resolved
@oncer
Copy link
Contributor Author

oncer commented Sep 4, 2019

Thank you for the hints, I've fixed the code as requested

@bjorn bjorn merged commit 8cd1858 into mapeditor:master Sep 4, 2019
@bjorn
Copy link
Member

bjorn commented Sep 4, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn bjorn bjorn requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oncer @bjorn