YY Plugin: Determine sprite names by looking for meta files #3213
Conversation
|
I added some caching and took care of the other review comments as well. However, the caching method will look up every empty string it receives as input. Before I add a check for that, I would rather hear your opinion on where it should be. It seems to me that placing it outside the method is the better approach as the method lacks the context to give the proper answer, even if it might always be an empty string at the moment. Finally, passing the context along feels a bit awkward, but I guess it is line with how the plugin is currently structured. |
There was a problem hiding this comment.
However, the caching method will look up every empty string it receives as input. Before I add a check for that, I would rather hear your opinion on where it should be.
You've already added the check, right? I think it's fine where it is. But when does this actually happen?
Finally, passing the context along feels a bit awkward, but I guess it is in line with how the plugin is currently structured.
I can see it must be a bit awkward to add this parameter in so many places. Alternatively we could rename Context to RoomWriter for example and move all these static functions into that class.
|
Should be done now, minus additional testing perhaps. |
Before assuming the name of an image file without its extension to be the name of the associated sprite, search the current and up to two parent directories for a *.yy meta file. If found, use its name without the file extension instead. A custom "sprite" property may still override this feature.
|
It looks good to me, nice work! Let's see how it behaves in the wild. :-) |
Before assuming the name of an image file without its extension to be the name of the associated sprite, search the current and up to two parent directories for a *.yy meta file. If found, use its name without the file extension instead.
A custom "sprite" property may still override this feature and will also prevent file system crawling.
This enables a user to use the sprite image files directly from their game project for image layers without having to specify the custom "sprite" property or using a copy with a proper name, as GameMaker Studio2 uses some UUID naming scheme for asset files.
The search is extended to parent directories as sprites resources also may contain subdirectories for individual layers. By the same token, a user may store different versions of an asset in the same folder. This is purely for added convenience so "it just works", even if a user merely wishes to have a Sprite be represented only by one of its layers.