Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TileSet Python export plugins (fixes #1865) #3857

Merged
merged 14 commits into from
May 24, 2024
Merged

Commits on Dec 12, 2023

  1. TileSet Python export plugins (fixes mapeditor#1865)

    Extended the Python plugin to support custom tileset exporters and readers written in Python.
    DrDub committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    86cfa26 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. Updated NEWS.md

    bjorn committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    b065185 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Configuration menu
    Copy the full SHA
    a4260fe View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. Changes from review

    DrDub committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    330e6e0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fc6b3c3 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Addressed some issues

    * Un-duplicated setPythonClass function
    
    * Removed unused pluginmanager.h include
    
    * Fixed cleanup code related to reloading plugins in case a plugin
      changes from defining a map format to a tileset format or vice versa.
    
    * Allow a Python plugin to include both a map and a tileset format
      (though only one of each).
    bjorn committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    8499992 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Configuration menu
    Copy the full SHA
    8c91ba3 View commit details
    Browse the repository at this point in the history
  2. Fixed Python include path not recognized in Qt Creator

    It appears Qt Creator's Qbs support does not include looking for compiler
    flags setting include paths (-I). They need to be actually set using
    cpp.includePaths.
    bjorn committed May 3, 2024
    Configuration menu
    Copy the full SHA
    d3c4e9d View commit details
    Browse the repository at this point in the history
  3. Also set cpp.defines for completeness

    There are actually no defines coming from python3-embed for me.
    bjorn committed May 3, 2024
    Configuration menu
    Copy the full SHA
    504854f View commit details
    Browse the repository at this point in the history
  4. Fixed repeated calls to findPluginSubclass

    The problem was that handleError was not called when PyObject_IsSubclass
    returned -1, which it commonly did when called with a value that wasn't
    a class. With the error indicator still set, the next call to
    PyObject_Dir was failing.
    
    Since the errors aren't usually very useful, we just call PyErr_Clear when
    PyObject_IsSubclass fails.
    
    I couldn't find a convenient way to check if the value is a class, which
    could avoid raising these errors in the first place.
    bjorn committed May 3, 2024
    Configuration menu
    Copy the full SHA
    5de036b View commit details
    Browse the repository at this point in the history
  5. Removed useless call to PyErr_Clear

    The PyErr_Print call already clears the error indicator, according to
    the docs.
    bjorn committed May 3, 2024
    Configuration menu
    Copy the full SHA
    a08a270 View commit details
    Browse the repository at this point in the history
  6. Name contributor in NEWS.md

    bjorn committed May 3, 2024
    Configuration menu
    Copy the full SHA
    e46a0d3 View commit details
    Browse the repository at this point in the history
  7. Consistent class order

    bjorn committed May 3, 2024
    Configuration menu
    Copy the full SHA
    c1332ad View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Configuration menu
    Copy the full SHA
    b654393 View commit details
    Browse the repository at this point in the history