TileSet Python export plugins (fixes #1865) #3857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extended the Python plugin to support custom tileset exporters and readers written in Python.
bjorn
requested changes
Jan 12, 2024
|
Let me know how it looks now. I think I got all the changes in. |
|
@DrDub I've pushed some changes, and also was running into a crash, likely the same you encountered. I've fixed it by adding a check on the return value of It appears there is something broken about |
* Un-duplicated setPythonClass function * Removed unused pluginmanager.h include * Fixed cleanup code related to reloading plugins in case a plugin changes from defining a map format to a tileset format or vice versa. * Allow a Python plugin to include both a map and a tileset format (though only one of each).
It appears Qt Creator's Qbs support does not include looking for compiler flags setting include paths (-I). They need to be actually set using cpp.includePaths.
There are actually no defines coming from python3-embed for me.
The problem was that handleError was not called when PyObject_IsSubclass returned -1, which it commonly did when called with a value that wasn't a class. With the error indicator still set, the next call to PyObject_Dir was failing. Since the errors aren't usually very useful, we just call PyErr_Clear when PyObject_IsSubclass fails. I couldn't find a convenient way to check if the value is a class, which could avoid raising these errors in the first place.
The PyErr_Print call already clears the error indicator, according to the docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended the Python plugin to support custom tileset exporters and readers written in Python.
I understand the Python plugin has its issues and the JavaScript plugin is preferred, but this extension might make it more useful. (The issue of system Python vs. Tiled Python sadly remains.)