Added functionality to swap tiles #866
Conversation
|
|
||
| const TilesetModel *model = tilesetModel(); | ||
| Tile *tile1 = model->tileAt(selectionModel()->selectedIndexes()[0]); | ||
| Tile *tile2 = model->tileAt(selectionModel()->selectedIndexes()[1]); |
There was a problem hiding this comment.
You're retrieving the list of selected indexes three times in this function. Please put it in a local variable.
|
Overall a nice and clean patch! One question though, why did you decide to only swap the tiles for the current layer? This is going to be painful for people who want to swap the tiles globally and have many layers, which seems to be part of your main use-case. Also, I guess it would make sense to support this on object layers for tile objects as well. |
- Swapping tiles triggers emitRegionChanged() for redrawing - "Swap tiles" -> "Swap Tiles". Added mnemonic as well in English. - Refactoring: Extracted variable
|
Thx 😄 To answer your question why only for tile layers and the current layer... I never worked with Qt before and it was my first time reading Tiled's source code as well, so my goal was to change so few as possible to avoid breaking something. Because I only have exactly one layer (a tile layer) I stuck with When doing this on all layers you would imagine that the tiles would be swapped on all layers - object layers and tile layers all at once? |
Sorry for the late answer, but yes that's what I would expect to happen. In general, I'm a little concerned that this action will be mistaken for a way to rearrange the tileset itself, rather than modifying the map. But I'll look into giving this a try and merging it sometime soon. |
|
Rebased on current master and pushed as 2c6cde6. The behavior is still the same (works on current tile layer only), but I'll change it to apply to the whole map. |
|
I made the swap affect the entire map in change b52338c. |
|
Hi, interested by TileSet rearrangement, can't find any way to use these on interface |
|
@tangorri Currently you can't modify the tileset image in Tiled. The change that was merged here is meant to help users who modified their tileset image externally, to adjust the maps they have already created. |
During development of my game I am frequently changing the graphics file of the tileset. It is pretty anonying that I destroy the map when moving around the tiles on the graphic. First I wrote a script to switch two ids in the map.
Because it is not very fun to look up ids which to switch, I decided that it would be nice if I can do this in Tiled directly. I found no such function... so I wrote one myself :-)
If exactly two tiles are selected you can selected "Swap tiles" in the contextmenu to swap these tiles on the current TileLayer.