Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed loading property jdbcDriver in template #1438

Merged
merged 1 commit into from Aug 11, 2020
Merged

Fixed loading property jdbcDriver in template #1438

merged 1 commit into from Aug 11, 2020

Conversation

MalteStr
Copy link
Contributor

When using property jdbcDriver in config.yaml, mapfish returns error

Unable to find property 'jdbcDrivers' on class: org.mapfish.print.config.Template
 in 'reader', line 13, column 18:
        jdbcDrivers: [org.postgresql.Driver]

Added now jdbcDriver-parameter to Template.java.

@sbrunner sbrunner changed the title fixed loading property jdbcDriver in template Fixed loading property jdbcDriver in template Aug 10, 2020
@sbrunner
Copy link
Member

Looks good, I will have a look on why the master is broken...

@sbrunner
Copy link
Member

I just see that the CI failed because you have some tab and trailing white space in your code...

@sbrunner
Copy link
Member

I just do a fix for pull request from external repository: #1439
If you do a rebase the CI should be fixed :-)

@sbrunner
Copy link
Member

Can you rebase your branch to remove the unwanted commits?

@MalteStr MalteStr force-pushed the fix_jdbcDriver branch 2 times, most recently from 0ab4a0f to 183c19f Compare August 11, 2020 09:24
@sbrunner
Copy link
Member

Thanks :-)

@sbrunner sbrunner merged commit 0065ee3 into mapfish:master Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrunner sbrunner sbrunner approved these changes

Assignees
No one assigned
Labels
no-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MalteStr @sbrunner