Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Gradle, Java, Tomcat and SpotBugs #1530

Merged
merged 1 commit into from Oct 23, 2020
Merged

Upgrade Gradle, Java, Tomcat and SpotBugs #1530

merged 1 commit into from Oct 23, 2020

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Oct 20, 2020 •
edited

@sbrunner sbrunner marked this pull request as ready for review October 20, 2020 11:34
gberaudo
gberaudo approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@gberaudo gberaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except that the scale bar is not exactly the same as before.

For exemple in https://github.com/mapfish/mapfish-print/pull/1530/files#diff-618ad6f49b6a1d8734a1e3be31841482aa1b5cddfe24cca0fcc643595ae77c12 you can see that in some cases it only spans 30km (instead of 60km in the old version).

There is a slight change in font rendering, could it be the reason of this difference?

@sbrunner
Copy link
Member Author

As the old one just feet is that I expect that's that, I create this commit and I see the original scale line:
dc23645

@sbrunner sbrunner merged commit 8c28f37 into master Oct 23, 2020
@sbrunner sbrunner deleted the tomcat branch October 23, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gberaudo gberaudo gberaudo approved these changes

@danduk82 danduk82 Awaiting requested review from danduk82

Assignees
No one assigned
Labels
no-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sbrunner @gberaudo