Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: statistics and report #672

Closed
wants to merge 16 commits into from
Closed

feat: statistics and report #672

wants to merge 16 commits into from

Conversation

YanNoun
Copy link
Member

@YanNoun YanNoun commented Nov 9, 2020

This PRs aims at adding two commands (compute_statistics) and (export_report), that allows computing various quality metrics of a dataset and export them as a nice PDF report :

  • compute_statistics will generate various image files (mostly plots) and a stats.jsopn file in the stats folder.
  • export_report will use the above to generate some PDF.

cc @pierotofy as it might be of interest for you.

See below for an example of the Red Rocks dataset (https://dronemapper.com/sample_data/) :
report.pdf

@pierotofy
Copy link
Contributor

This is amazing ❤️

What a wonderful addition!

@smathermather
Copy link

Yeah, this is one of the most commonly requested features in OpenDroneMap. Folx are going to be ecstatic.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YanNoun has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@YanNoun merged this pull request in 8914d02.

@YanNoun
Copy link
Member Author

YanNoun commented Jan 7, 2021

@pierotofy it's finally merged !

@pierotofy
Copy link
Contributor

Can't wait to try this!

Thanks for this awesome addition @YanNoun

mlopezantequera pushed a commit that referenced this pull request Jan 28, 2021
* origin/master: (29 commits)
  build: use C++14 (#697)
  Fix parameter names
  vlfeat: avoid build warnings
  fix: GPS Altitude extraction (#648)
  Add new cameras to exif
  Add radial and simple_radial model to io
  Camera tests clean-up (4/n)
  Add SimpleRadial as Radial unit test (3/n)
  Add projection functions for radial/simple_radial (2/n)
  Add Radial/Simple_Radial types and create methods (1/n)
  Clean-up remaining Eigen::XX types
  Add unit tests for fisheye/fisheye62
  Fix: Return all distortion parameters from Python
  Add static method to get projection string
  fix: relax camera focal to prevent holes
  feat: statistics and report (#672)
  fix: no make_unique pre-C++14 (#688)
  feat: download merge rounds
  feat: add tracks merging
  Add option to use different cameras for images with unknown camera models
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants