Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle mouse up not fired outside of window #342

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

oscarlorentzon
Copy link
Member

Motivation

Handle released right mouse drag outside of window to avoid drag rotating without buttons pressed.

Contribution

(If this PR adds or changes functionality, describe it here.)

Test Plan

yarn build
yarn test
yarn start
  1. Start right mouse drag in in spatial view
  2. Release right mouse outside of the browser window
  3. Move the mouse cursor inside the window again
  4. No interaction occurs until mouse press again

@oscarlorentzon oscarlorentzon added this to the 4.0.0 milestone Mar 15, 2021
@oscarlorentzon oscarlorentzon merged commit 0e34309 into main Mar 15, 2021
@oscarlorentzon oscarlorentzon deleted the feature-right-mouse-up branch March 15, 2021 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants