Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor interfaces, events, data contracts, extension APIs and properties #345

Merged
merged 25 commits into from
Mar 22, 2021
Merged

Refactor interfaces, events, data contracts, extension APIs and properties #345

merged 25 commits into from
Mar 22, 2021

Conversation

oscarlorentzon
Copy link
Member

@oscarlorentzon oscarlorentzon commented Mar 22, 2021 •
edited
Loading

Motivation

Public API that has clearer types, better documentation, and improved property names.

Contribution

Rename interfaces, document events, change property names, change property types.

Test Plan

yarn prepare
yarn test
yarn start

@oscarlorentzon
refactor: rename interfaces for clarity
f614d66
@oscarlorentzon
refactor: unified camera type naming
6266fac
@oscarlorentzon
refactor: replace k1, k2, focal with camera parameters
87ff81f
@oscarlorentzon
refactor: clarify ent structure and node names
73fe9c4
@oscarlorentzon
refactor: rename key to id
618eb34
@oscarlorentzon
refactor: convert falcor data
53ee040
@oscarlorentzon
fix: use spherical when camera type is spherical
db852c4
@oscarlorentzon
refactor: precompute camera matrix inverses
8b0ff2e 
Improve performance for tags, popups, spatial,
render camera etc by avoiding costly
matrix inversion for each unproject.
@oscarlorentzon
fix: falcor core result format and spherical bearing
4876db3
@oscarlorentzon
refactor: provider method names correspond to contracts
608bbe6
@oscarlorentzon
refactor: move helper functions to common module
89bdd71
@oscarlorentzon
refactor: use spherical literal for panoramas
52a678a
@oscarlorentzon
refactor: make non ents contracts
b42347b
@oscarlorentzon
refactor: rename creator and owner props
c4c8bb8
@oscarlorentzon
refactor: fixed thumb size
c09055d 
Move image size enum to Falcor namespace
because it is only relevant there.
Do not fetch higher res image on halt.
Make thumb and mesh url ents.
@oscarlorentzon
feat: make relevant spatial props optional
1672360 
Document behavior if props not set.
@oscarlorentzon
feat: add render pass selection to custom renderer
931bf01 
Only opaque exist so far.
@oscarlorentzon
fix: correct file name for dist style
8b07652
@oscarlorentzon
refactor: graphql style sequence contract
3498605
@oscarlorentzon
refactor: graphql style spatial images contract
0a9cba1
@oscarlorentzon
refactor: graphql style images contract
092d0a4
@oscarlorentzon
refactor: graphql style core images contract
8e69051
@oscarlorentzon
refactor: separate folders for all components
53f21d3
@oscarlorentzon
chore: replace doc mentions of key with id
5f81236
@oscarlorentzon
refactor: type and document events
60dfa1c
@oscarlorentzon oscarlorentzon added this to the 4.0.0 milestone Mar 22, 2021
@oscarlorentzon oscarlorentzon changed the title Refactor interface, event, and property names Refactor interfaces, events, data contracts, extension APIs and properties Mar 22, 2021
@oscarlorentzon oscarlorentzon merged commit 9df6d32 into main Mar 22, 2021
@oscarlorentzon oscarlorentzon deleted the feature-interface-names branch March 22, 2021 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oscarlorentzon @facebook-github-bot