Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Camera Controls API #373

Merged
merged 3 commits into from
Apr 27, 2021
Merged

Custom Camera Controls API #373

merged 3 commits into from
Apr 27, 2021

Conversation

oscarlorentzon
Copy link
Member

Motivation

Make it possible to attach custom written camera controls to freely move the viewer camera.

Contribution

  • Custom camera controls interface defining the structure for implementers
  • Custom state and render service using custom controls callback params
  • Custom camera controls wrapper invoking interface methods
  • Unit tests

Test Plan

yarn lint
yarn build
yarn test
yarn start

@oscarlorentzon
feat: custom camera controls api
5adbbde 
Allow MJS to be controlled by any camera
interaction logic through a custom
camera controls API with an interface
defining the required methods to
implement.
@oscarlorentzon
docs: document custom camera controls api
8c502a8
@oscarlorentzon
test: unit test custom camera controls api
015ed4b
@oscarlorentzon oscarlorentzon added this to the 4.0.0 milestone Apr 27, 2021
@oscarlorentzon oscarlorentzon changed the title Feature camera controls Custom Camera Controls API Apr 27, 2021
@oscarlorentzon oscarlorentzon merged commit 43927cb into main Apr 27, 2021
@oscarlorentzon oscarlorentzon deleted the feature-camera-controls branch April 27, 2021 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oscarlorentzon @facebook-github-bot