Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render visible items on spatial activation #390

Merged
merged 1 commit into from
May 4, 2021
Merged

Render visible items on spatial activation #390

merged 1 commit into from
May 4, 2021

Conversation

oscarlorentzon
Copy link
Member

@oscarlorentzon oscarlorentzon commented May 4, 2021 •
edited
Loading

Motivation

Ensure that visible items are rendered immediately on spatial activation.

Contribution

  • Keep cell grid of configurable depth at uncaching so that valid spatially visualized cells are not uncached in graph
  • Re-emit all cells to all subscriptions in spatial component
  • Refactor cell math to make it reusable and unit test
  • Reset spatial scene completely on deactivation

Test Plan

yarn build
yarn test
yarn start

@oscarlorentzon
fix: render visible items on spatial activation
6d106ec 
Replay all cells for all subscriptions.
Ensure that valid spatially visualized
cells are not uncached in graph.
Reset scene completely on deactivation.
@oscarlorentzon oscarlorentzon added this to the 4.0.0 milestone May 4, 2021
@oscarlorentzon oscarlorentzon merged commit 03b50a9 into main May 4, 2021
@oscarlorentzon oscarlorentzon deleted the feature-spatial-activation branch May 4, 2021 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oscarlorentzon @facebook-github-bot