Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove event listeners correctly #430

Merged
merged 1 commit into from
Jun 3, 2021
Merged

Remove event listeners correctly #430

merged 1 commit into from
Jun 3, 2021

Conversation

oscarlorentzon
Copy link
Member

Contribution

  • Remove event handlers correctly from event emitter
  • Add unit tests ensuring that event handlers are removed correctly

Test Plan

yarn test
yarn start

@oscarlorentzon oscarlorentzon added this to the v4.0.0 milestone Jun 3, 2021
@oscarlorentzon oscarlorentzon merged commit 0d904a6 into main Jun 3, 2021
@oscarlorentzon oscarlorentzon deleted the feature-event-emitter branch June 3, 2021 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oscarlorentzon @facebook-github-bot