Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: detach custom camera controls correctly #474

Merged
merged 1 commit into from
Nov 8, 2021
Merged

fix: detach custom camera controls correctly #474

merged 1 commit into from
Nov 8, 2021

Conversation

oscarlorentzon
Copy link
Member

Motivation

Ensure that onDetach is only called once on custom camera control instances when detached.

Contribution

  • Only call onDetach once.
  • Unit test.
  • Return camera controls in promise when detaching.

Test Plan

yarn test

@oscarlorentzon oscarlorentzon added this to the v4.1.0 milestone Nov 8, 2021
@oscarlorentzon
fix: detach custom camera controls correctly
208b5ae 
Only detach once. Unit test.
Return camera controls in promise when detaching.
@oscarlorentzon oscarlorentzon merged commit b3c694f into main Nov 8, 2021
@oscarlorentzon oscarlorentzon deleted the feature-camera-detach branch November 8, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
v4.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oscarlorentzon @facebook-github-bot