Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify how custom renderers should use on remove method #517

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Clarify how custom renderers should use on remove method #517

merged 1 commit into from
Mar 2, 2022

Conversation

oscarlorentzon
Copy link
Member

Motivation

Make documentation clearer.

Contribution

Clarifications on how the onRemove method should mirror the onAdd method.

Test Plan

yarn --cwd doc build

@oscarlorentzon oscarlorentzon added this to the v4.1.0 milestone Mar 2, 2022
@oscarlorentzon oscarlorentzon self-assigned this Mar 2, 2022
@oscarlorentzon oscarlorentzon merged commit 0fe3427 into main Mar 2, 2022
@oscarlorentzon oscarlorentzon deleted the feature-renderer-docs branch March 2, 2022 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oscarlorentzon oscarlorentzon

Labels
cla signed
Projects
None yet
Milestone
v4.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oscarlorentzon @facebook-github-bot