[Controller] Controller Structure Prototype, DocStrings #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubix982
added
enhancement
facebook-github-bot
added
the
CLA Signed
cbeddow
reviewed
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces basic function prototypes for controllers needed in
controller/, each controller is created concerning each requirement, and has been labeled so. DocStrings are appropriately added, with a future PR relating to checking the correctkeyword argumentsto make sure nothing invalid is passed.The above is meant to slightly mitigate, but not completely solve, the issue mentioned in #48 - @OmarMuhammedAli can this PR do more to help with it? This PR only shows the options on an exception, but not whenever a user might request
help.Integrates and includes changes introduced in #54.
This can serve as a basis for quickly iterating over the requirements independently.
Closes #55.
Compliments #57.