feat: added set style method on controller #444
Conversation
…hout rebuilding map
# Conflicts: # example/lib/local_style.dart
There was a problem hiding this comment.
Hi @itheamc, thank you for keeping your pull request updated with the main branch.
The user has the option to add annotations like circles, symbols and so on. After the user changes the style of the map the annotations added by the user should be still on the map to avoid an inconcistent state between flutter and the maplibre SDKs.
| try { | ||
| _map.setStyle(styleString); | ||
| } on PlatformException catch (e) { | ||
| return Future.error(e); | ||
| } |
There was a problem hiding this comment.
When does _map.setStyle throw a PlatformException? (It's not used in the other methods.)
example/lib/local_style.dart
Outdated
| onMapCreated: _onMapCreated, | ||
| initialCameraPosition: const CameraPosition(target: LatLng(0.0, 0.0)), | ||
| onStyleLoadedCallback: onStyleLoadedCallback, | ||
| )); |
There was a problem hiding this comment.
Adding the option to change the map to this example could be confusing because this example showcases that the map style can in general be loaded from an local source. Could you create a new page that showcases this functionality please?
|
Hi @itheamc, I've seen that you clicked on "Resolve conversations" for my comments but 4 haven't been implemented. Could you give some quick details what's the reason please? |
No description provided.