-
-
Notifications
You must be signed in to change notification settings - Fork 651
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove finalize elevation when updating elevation on the fly (#3944)
* Fix for #3878 Don't _finalizeElevation if freezeElevation has not been set. This means that elevation logic has two distinct operating modes. Mode one - freezeElevation is false - default: - updateElevation is called continuously during the movement - finalizeElevation is *not* called at the end. Mode two - freezeElevation is true: - updateElevation is *not* called continuoulsy during the movement - finalizeElevation is called at the end. Previously, both methods were called in mode one, which lead to issue #3878 if freezeElevation was not set. * Fix for #3878 - address review comments (done -> async) * Update src/ui/camera.test.ts * Fix for #3878 - address review comments 2 --------- Co-authored-by: Harel M <harel.mazor@gmail.com>
- Loading branch information
Showing
3 changed files
with
36 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters