-
-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove finalize elevation when updating elevation on the fly #3944
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3944 +/- ##
==========================================
+ Coverage 86.49% 86.76% +0.27%
==========================================
Files 242 242
Lines 33041 33041
Branches 2036 2012 -24
==========================================
+ Hits 28578 28669 +91
+ Misses 3481 3404 -77
+ Partials 982 968 -14 ☔ View full report in Codecov by Sentry. |
This fix makes sense to me regardless of what I wrote in the issue. |
Can you add a test and a changelog item? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also think this change makes absolutely sense!
Don't _finalizeElevation if freezeElevation has not been set. This means that elevation logic has two distinct operating modes. Mode one - freezeElevation is false - default: - updateElevation is called continuously during the movement - finalizeElevation is *not* called at the end. Mode two - freezeElevation is true: - updateElevation is *not* called continuoulsy during the movement - finalizeElevation is called at the end. Previously, both methods were called in mode one, which lead to issue maplibre#3878 if freezeElevation was not set.
d1b29ef
to
26c3e90
Compare
Added a test, updated the changelog. |
Don't _finalizeElevation if freezeElevation has not been set.
This means that elevation logic has two distinct operating modes.
Mode one - freezeElevation is false - default:
Mode two - freezeElevation is true:
Previously, both methods were called in mode one, which lead to issue #3878 if freezeElevation was not set.
Fixes #3878
Launch Checklist
CHANGELOG.md
under the## main
section.