New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metal debug render tests #1855
Closed
alexcristici
wants to merge
60
commits into
maplibre:main
from
alexcristici:metal-debug-render-tests
Closed
Metal debug render tests #1855
alexcristici
wants to merge
60
commits into
maplibre:main
from
alexcristici:metal-debug-render-tests
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…istici/maplibre-native into metal-symbol-render-tests
for more information, see https://pre-commit.ci
… order to debug it.
Closed
for more information, see https://pre-commit.ci
…stici/maplibre-native into metal-debug-render-tests
Bloaty Results 🐋Compared to main
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-1855-compared-to-main.txtCompared to d387090 (legacy)
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-1855-compared-to-legacy.txt |
…d pattern shader.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…stici/maplibre-native into metal-debug-render-tests
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current status - 4 failing render tests:
2 will be fixed after triangulated lines will support data driven properties:
render-tests/fill-outline-color/zoom-and-property-function
render-tests/fill-outline-color/property-function
2 are failing because of the layer z-fighting #1847:
render-tests/text-pitch-alignment/map-text-depthtest
render-tests/fill-extrusion-color/function