-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metal debug lines #1888
Metal debug lines #1888
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1888 +/- ##
==========================================
+ Coverage 85.73% 85.75% +0.02%
==========================================
Files 568 568
Lines 28027 28026 -1
==========================================
+ Hits 24029 24034 +5
+ Misses 3998 3992 -6 ☔ View full report in Codecov by Sentry. |
Bloaty Results 🐋Compared to main
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-1888-compared-to-main.txtCompared to d387090 (legacy)
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-1888-compared-to-legacy.txt |
Should we enable this for both platforms or just for Metal? |
Rather use the GL lines on GL if we can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the polyline generator to create triangulated lines for tile borders in Metal.
Ref: #1855