Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metal debug lines #1888

Merged
merged 16 commits into from
Nov 28, 2023
Merged

Metal debug lines #1888

merged 16 commits into from
Nov 28, 2023

Conversation

stefankarschti
Copy link
Collaborator

Use the polyline generator to create triangulated lines for tile borders in Metal.

image

Ref: #1855

@stefankarschti stefankarschti self-assigned this Nov 22, 2023
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b99b833) 85.73% compared to head (30a5caa) 85.75%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1888      +/-   ##
==========================================
+ Coverage   85.73%   85.75%   +0.02%     
==========================================
  Files         568      568              
  Lines       28027    28026       -1     
==========================================
+ Hits        24029    24034       +5     
+ Misses       3998     3992       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 23, 2023

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0% +4.58Ki  +0.0% +1.70Ki    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-1888-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +19% +22.1Mi  +403% +24.1Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-1888-compared-to-legacy.txt

@stefankarschti
Copy link
Collaborator Author

Should we enable this for both platforms or just for Metal?

@sjg-wdw
Copy link
Collaborator

sjg-wdw commented Nov 27, 2023

Rather use the GL lines on GL if we can.

Copy link
Collaborator

@alexcristici alexcristici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

Before:
Before

After:
After

@stefankarschti stefankarschti marked this pull request as ready for review November 27, 2023 18:51
@stefankarschti stefankarschti merged commit 178454b into main Nov 28, 2023
32 checks passed
@stefankarschti stefankarschti deleted the metal-debug-lines branch November 28, 2023 05:51
louwers pushed a commit to louwers/maplibre-native that referenced this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants