Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RasterTile / mailbox fix #2443

Merged
merged 7 commits into from
May 30, 2024
Merged

Conversation

TimSylvester
Copy link
Collaborator

Shut down the mailbox on raster tiles as with GeometryTile to avoid processing messages after it's queued for destruction

… processing messages after it's queued for destruction
@TimSylvester TimSylvester added the bug Something isn't working label May 28, 2024
@TimSylvester TimSylvester self-assigned this May 28, 2024
Copy link

github-actions bot commented May 29, 2024

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0% +31.9Ki  +0.0% +9.67Ki    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2443-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +21% +24.1Mi  +409% +24.4Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2443-compared-to-legacy.txt

Copy link

github-actions bot commented May 29, 2024

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            -0.0140         -0.0132             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2443-compared-to-main.txt

This occurred from `~TileLoader` as called by `~RasterTile`.
Copy link

github-actions bot commented May 29, 2024

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0% +6.79Ki  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2443-compared-to-main.txt

@TimSylvester TimSylvester marked this pull request as ready for review May 29, 2024 21:54
@TimSylvester TimSylvester requested a review from mwilsnd May 29, 2024 21:54
Copy link
Collaborator

@sjg-wdw sjg-wdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the changes outside of raster tile loading, I'd like to see some stress testing before we merge to main. Maybe some multi map test for both raster and vector?

@TimSylvester TimSylvester merged commit 2a09100 into maplibre:main May 30, 2024
33 of 34 checks passed
@TimSylvester TimSylvester deleted the bug/raster-mailbox branch May 30, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants