Annotation view recycling re-enabled #2454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcristici
requested review from
louwers,
cgalvan,
mwilsnd,
TimSylvester and
sjg-wdw
sjg-wdw
approved these changes
May 30, 2024
|
I tested on my iPhone 6s with iOS 15 and it fixes the original bug. I tested without the |
|
Works for me |
mwilsnd
approved these changes
May 30, 2024
|
I added some screen recording. |
cgalvan
approved these changes
May 30, 2024
louwers
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverted code that disabled annotation view recycling, from this PR: #2148.
We don't need that workaround after fixing the
presentsWithTransactionrendering in this PR: #2442.Before
presentsWithTransactionfix:Before.MP4
After
presentsWithTransactionfix:After.MP4