-
-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node platform improvements #891
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This help with several functions exposed by #871 , like SetCenter, SetZoom, SetBearing, not working because because there was no way to call render without changing the view. I think this is an improvement and consistent with other plaform syntax.
I have worked with @tdcosta100 in testing this and it seems to work as expected, the SetCenter, SetZoom, SetBearing functions can now be used.
Tests have been added that show this syntax works.
@tdcosta100 before we merge this can you add a entry to the readme under the 5.2.0 release (we haven't released this yet) https://github.com/maplibre/maplibre-gl-native/blob/main/platform/node/CHANGELOG.md |
Done! |
This PR brings some improvements to the Node platform:
void mbgl::Map::renderStill(StillImageCallback)
methodNodeMap::RenderOptions
)Bonus: a little addition to the code example at README.md when the status code is 204 (empty response).