Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node platform improvements #891

Merged
merged 14 commits into from
Mar 9, 2023
Merged

Conversation

tdcosta100
Copy link
Contributor

This PR brings some improvements to the Node platform:

Bonus: a little addition to the code example at README.md when the status code is 204 (empty response).

@tdcosta100 tdcosta100 marked this pull request as draft March 8, 2023 19:39
@tdcosta100 tdcosta100 marked this pull request as ready for review March 8, 2023 19:44
@acalcutt acalcutt added the node label Mar 8, 2023
Copy link
Collaborator

@acalcutt acalcutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This help with several functions exposed by #871 , like SetCenter, SetZoom, SetBearing, not working because because there was no way to call render without changing the view. I think this is an improvement and consistent with other plaform syntax.

I have worked with @tdcosta100 in testing this and it seems to work as expected, the SetCenter, SetZoom, SetBearing functions can now be used.

Tests have been added that show this syntax works.

@acalcutt
Copy link
Collaborator

acalcutt commented Mar 9, 2023

@tdcosta100 before we merge this can you add a entry to the readme under the 5.2.0 release (we haven't released this yet)

https://github.com/maplibre/maplibre-gl-native/blob/main/platform/node/CHANGELOG.md

@tdcosta100
Copy link
Contributor Author

Done!

@acalcutt acalcutt merged commit 9766f6f into maplibre:main Mar 9, 2023
@tdcosta100 tdcosta100 deleted the mbgl-node-enhancements branch March 9, 2023 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants