Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MapLibre GL Native for Android and other things #21

Merged
merged 8 commits into from
May 7, 2023

Conversation

louwers
Copy link
Collaborator

@louwers louwers commented Mar 1, 2023

  • Updated Android Gradle Plugin
  • Update kotlin-android-extensions (and view bindings)
  • Updated Kotlin
  • Updated MapLibre GL Native for Android
  • Removed Style.MAPBOX_STREETS etc., use Style.getPredefinedStyle instead (using MapTiler).

The test app build and runs again. But every activity needs to have a well known tile server set explicitly to function. I only updated the BulkSymbolActivity now. The markers do not appear yet but as soon as that is fixed I would like to merge this.

@fynngodau
Copy link
Collaborator

fynngodau commented Mar 14, 2023

But every activity needs to have a well known tile server set explicitly to function.

Possibly it might be a good idea to subclass Activity / AppCompatActivity and call Mapbox.getInstance in that new superclass' onCreate?

I only updated the BulkSymbolActivity now. The markers do not appear yet but as soon as that is fixed I would like to merge this.

The problem is here:

The icon fire-station-11 is undefined because you changed the map's style. We can add such an icon again and then it will work again :) Here is a patch that uses the fire hydrant icon from Google's material design and gets us the icons back:

the-icons-are-back

Copy link
Collaborator

@fynngodau fynngodau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific reason you changed the indent in some of the files? Was it misaligned across the different files?

app/build.gradle Show resolved Hide resolved
gradle/dependencies.gradle Show resolved Hide resolved
@louwers
Copy link
Collaborator Author

louwers commented Mar 14, 2023

@fynngodau Wow thanks with the icon!!

Good catch.

@louwers louwers marked this pull request as ready for review March 24, 2023 17:27
@fynngodau fynngodau linked an issue Mar 24, 2023 that may be closed by this pull request
app:mapbox_cameraTargetLat="37.769145"
app:mapbox_cameraTargetLng="-122.447244"
app:mapbox_cameraZoom="15.5" />
app:maplibre_cameraTargetLat="37.769145"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice to see maplibre here!

@fynngodau fynngodau mentioned this pull request Apr 24, 2023
Copy link
Collaborator

@fynngodau fynngodau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the indentation should be correct

Copy link

@ovivoda ovivoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@louwers louwers merged commit f7fb206 into maplibre:main May 7, 2023
1 check failed
@fynngodau fynngodau mentioned this pull request Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align minSdkVersion
3 participants