-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MapLibre GL Native for Android and other things #21
Conversation
Possibly it might be a good idea to subclass Activity /
The problem is here: Line 158 in e81c1bb
The icon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a specific reason you changed the indent in some of the files? Was it misaligned across the different files?
@fynngodau Wow thanks with the icon!! Good catch. |
app/src/main/java/com/mapbox/mapboxsdk/plugins/testapp/activity/ktx/maps/MapboxKtxActivity.kt
Outdated
Show resolved
Hide resolved
...main/java/com/mapbox/mapboxsdk/plugins/testapp/activity/localization/LocalizationActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/mapbox/mapboxsdk/plugins/testapp/activity/scalebar/ScalebarActivity.kt
Outdated
Show resolved
Hide resolved
app:mapbox_cameraTargetLat="37.769145" | ||
app:mapbox_cameraTargetLng="-122.447244" | ||
app:mapbox_cameraZoom="15.5" /> | ||
app:maplibre_cameraTargetLat="37.769145" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice to see maplibre here!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now the indentation should be correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Style.MAPBOX_STREETS
etc., useStyle.getPredefinedStyle
instead (using MapTiler).The test app build and runs again. But every activity needs to have a well known tile server set explicitly to function. I only updated the BulkSymbolActivity now. The markers do not appear yet but as soon as that is fixed I would like to merge this.