Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to display the tile boundaries #202

Closed
pathmapper opened this issue Nov 29, 2017 · 13 comments
Closed

Option to display the tile boundaries #202

pathmapper opened this issue Nov 29, 2017 · 13 comments

Comments

@pathmapper
Copy link
Contributor

It would be useful to have an option to display the tile boundaries (https://www.mapbox.com/mapbox-gl-js/api/#map#showtileboundaries). See also: #41 (comment)

@justenPalmer
Copy link
Contributor

Where do you guys think this should be implemented in the interface? One potential option would be to automatically show tile boundaries when in inspect mode.

@pathmapper
Copy link
Contributor Author

automatically show tile boundaries when in inspect mode

I like your idea @justenPalmer. Personally I wouldn't need a toggle to switch them on/off.

@orangemug
Copy link
Collaborator

Would showing tile boundaries by default be confusing? I'm thinking that there are a number of straight lines and right angles on the map already, the US state boundaries for example.

Tile boundaries are not a thing you have to consider most of the time, I think it might just clutter the inspect view if enabled by default. Thoughts?

@pathmapper
Copy link
Contributor Author

Would showing tile boundaries by default be confusing?

You're right @orangemug . It really depends on the specific use case and the data.

A toggle to switch them on/off could be placed somewhere in the near of the existing controls, but I would be happy with any implementation.

image

@pathmapper
Copy link
Contributor Author

Or what about a context menu which opens on a right-click?

There could be also other settings located in such a context menu, e.g. a toggle to switch on/off the zoom control buttons on the map.

@orangemug
Copy link
Collaborator

@pathmapper In issue #252 I've outlined a small change to the UI. We could include a general 'debug' panel in that proposed UI in which you could turn on things like 'tile boundaries', thoughts?

@pathmapper
Copy link
Contributor Author

👍 for your suggestion @orangemug!

Maybe in such a 'debug' panel it could be also possible to turn on/off the map navigation controls and the zoom level information (default: on):

auswahl_110

Personally I don't use the navigation controls and the hash zoom level is sufficient for me. Having the ability to turn them off, it would be possible to have more of the map visible which would be useful on low resolution screens.

@orangemug
Copy link
Collaborator

@pathmapper the master branch now supports ?show-tile-boundaries querystring parameter. I'll release a new version towards the end of the week.

This is a partial solution before we get around to a 'debug settings panel'

@kateler
Copy link

kateler commented Aug 21, 2018

Is there an explanation somewhere for how to use this new feature? I tried tacking "?show-tile-boundaries" on to the end of the URL but it did nothing.

@orangemug
Copy link
Collaborator

No docs as it was intended to be a first pass, towards a UI. For those that need this feature https://maputnik.github.io/editor/?show-tile-boundaries=true#4.87/55.33/0.07 should give you want to need.

@kateler
Copy link

kateler commented Aug 21, 2018

Thanks! Once I included the "=true" it worked.

@gregwolanski
Copy link
Contributor

This issue appears in the answers to question “What annoys you about Maputnik?” in the survey (original spelling):

  • no debugging (tile boundaries/collision boxes/overdraw)

@pathmapper
Copy link
Contributor Author

no debugging (tile boundaries/collision boxes/overdraw)

These three options are available now using a query parameter, closing here in favor of #460.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants