Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcut fixes #448

Merged
merged 2 commits into from
Oct 31, 2018
Merged

Shortcut fixes #448

merged 2 commits into from
Oct 31, 2018

Conversation

orangemug
Copy link
Collaborator

  • Allow shortcuts to trigger from the shortcut modal
  • Fix inspect/map toggle shortcut

 - Allow shortcuts to trigger from the shortcut modal
 - Fix inspect/map toggle shortcut
@pathmapper
Copy link
Contributor

pathmapper commented Oct 29, 2018

? for the shortcut menu is not working for the German keyboard layout (need to press Shift + ß to display ?).

Also I wonder what should be exactly the effect of m (Focus map).

@orangemug
Copy link
Collaborator Author

? for the shortcut menu is not working for the German keyboard layout (need to press Shift + ß to display ?).

@pathmapper I just added a commit in an attempt to fix this. Could you give it a test let me know if it works. The new build is https://1154-84182601-gh.circle-artifacts.com/0/artifacts/build/index.html

Also I wonder what should be exactly the effect of m (Focus map).

This need better documenting but with the map focused you can use arrow keys to move the map and also zoom with +/- (see #256 (comment))

@pathmapper
Copy link
Contributor

Could you give it a test let me know if it works.

Yes, it works now 🎉

with the map focused you can use arrow keys to move the map and also zoom with +/-

Got it, thanks!

@orangemug orangemug merged commit c51c40a into maplibre:master Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants