Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Rustls #474

Merged
merged 7 commits into from
Sep 30, 2023
Merged

Switch to Rustls #474

merged 7 commits into from
Sep 30, 2023

Conversation

nyurik
Copy link
Member

@nyurik nyurik commented Nov 2, 2022

Fixes #471

@nyurik nyurik marked this pull request as ready for review November 3, 2022 16:44
@nyurik
Copy link
Member Author

nyurik commented Nov 3, 2022

@stepankuzmin I have no idea how to test the SSL certs - but the code is done otherwise, so if you can manually test it and it works, feel free to +1

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2023

Codecov Report

Base: 57.37% // Head: 56.28% // Decreases project coverage by -1.09% ⚠️

Coverage data is based on head (b1f1c8e) compared to base (23553cc).
Patch coverage: 18.75% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #474      +/-   ##
==========================================
- Coverage   57.37%   56.28%   -1.09%     
==========================================
  Files          30       30              
  Lines        2557     2679     +122     
==========================================
+ Hits         1467     1508      +41     
- Misses       1090     1171      +81     
Impacted Files Coverage Δ
src/args/pg.rs 83.81% <ø> (-0.91%) ⬇️
src/lib.rs 30.31% <ø> (-2.10%) ⬇️
src/pg/config.rs 86.86% <ø> (+0.41%) ⬆️
src/pg/pool.rs 32.65% <0.00%> (-2.91%) ⬇️
src/pg/utils.rs 44.26% <0.00%> (-13.19%) ⬇️
src/pg/tls.rs 67.64% <30.76%> (-30.54%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nyurik
Copy link
Member Author

nyurik commented Feb 12, 2023

current code seem to be passing tests, but i suspect it won't allow verify-ca mode, or when a root cert is given (we still need tests for that)

@nyurik nyurik merged commit 8d7204c into maplibre:main Sep 30, 2023
23 checks passed
@nyurik nyurik deleted the rustls branch September 30, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use rustls crate instead of openssl
3 participants