-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds search; adds resize; adds dynamic layer color; #660
Conversation
This is awesome!!! Thank you! I especially like the search capability. So some feedback:
In short, thank you for working on this!!! |
@nyurik I am still stuck on this part. This is what I have researched upto now: Now I want to ask
If there is no way to detect geometry type of vector tiles in client side then I have thought or few workarounds
{
"MixPoints": "POINTS",
"points1": "POINTS"
} This approach obviously defies purpose of getting all layers and plotting them automatically. This is the most easy approach. This is all I have found till now. Your guidance here will be very much helpful. |
@Binabh thanks for all the hard work on this! Try this:
You are now seeing the Maputnik inspector mode -- all geometries. If you look at the tilejson, you will see that it does have the The issue with the server-side geometry generation is that I am not certain if we can compute the type without a full table scan -- something I would obviously want to avoid, esp on startup. |
@nyurik I think I cannot do this in client side with data we are currently getting. About Inspect mode I think it displays layer type like the one given here. In our case its always circle by this function as the value of geometry type is always undefined. I am also open to any other suggestions. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks awesome! Let's merge as is for now. Once we figure out how to visualize everything, we may even make something like this a starting page
P.s. I'll have to look into auto detection a bit more myself. Problem is, we may not always have a way to detect what type of geometry each layer has, eg if it comes from mbtiles or pmtiles source |
Thank you @nyurik . I will also continue my research on this. Trying to solve this issue I learned a lot about vectortiles, maplibre and martin. I will try to be involved as much as possible. |
@tomeronen the closest is the https://github.com/maplibre/martin/blob/main/tests/debug.html - which I would love to abandon and have a proper Martin UI instead. Feel free to create a new issue and/or just hack on a new PR. Noone's working on it AFAIK. |
@nyurik i did some work on this and created a basic version that is more like maputnik and a basic version that is more like kepler.gl. Kepler is data focused compared, to maputnik which is more focused on creating a mapbox style. Currently thinking on going the kepler.gl route. I can start with a fork with a basic version and add more functionality along the way |
Created a basic poc (still wip) for a possible UI. |
show lines and polygons
show all layers regardless of their name
different color for each layer
make left sidebar resizable
add search box
closes Improve MapLibre demo to show all available lines/points/polygons from all sources #536