-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error messages for import URL and GeoJSON-Response #68
Comments
i agree. there is serious room for improvement in our current validation. right now we:
Line 524 in 2656b4d
we aren't validating the feature JSON at all. To make things a little more complicated, the query operation of modern geoservices is capable of emitting native GeoJSON (which include side by side comparison: https://gist.github.com/jgravois/eab035258f8157d54618 currently we first fetch only metadata from the service to see whether it supports asking for native GeoJSON. If it doesn't we ask for Esri/Geoservice feature JSON and convert it into GeoJSON for Line 393 in 2656b4d
what you're trying to do is just store valid GeoJSON in a flat file on a server. a bit of refactoring of our code would necessary to short circuit the series of API calls we currently make once we are convinced the user has supplied a geoservice url. right now we: b) first, fetch only a count of the features within the supplied bounding box c) then fetch a count of the total number of features stored behind the entire service d) lastly, fetch only the features within the supplied bounding box (using |
I am still trying to use the importer with #66.
ATM my problem is either the url format or the json format.
Unfortunatelly the importer is not very helpful in understanding and solving the error.
Ideally, the importer would talk to me about:
URL
JSON
Testcases
attributes
, minimalproperties
, minimalproperties
, with contentattributes
, with contentUse
properties
orattributes
?The example URL from #66 (comment) @jgravois uses a
properties
. The http://geoservices.github.io/ example, that was referenced before, usesattributes
.Other usability improvements
Use case: I input an url -> see an error message -> change the URL -> see the same error message.
ATM it is not clear if the "second" error message is still the same as before or if the new URL still creates an (new) error.
The text was updated successfully, but these errors were encountered: