Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testcase: Trees of Berlin #66

Open
tordans opened this issue Mar 28, 2018 · 6 comments
Open

Testcase: Trees of Berlin #66

tordans opened this issue Mar 28, 2018 · 6 comments

Comments

@tordans
Copy link

tordans commented Mar 28, 2018

Hi, I would like to test the feature with Trees in Berlin.
However, http://mapmeld.com/iD/ does not seem to load and https://api06.dev.openstreetmap.org (from openstreetmap#4633 (comment)) does not let me log in (it probably has a whitelist for accounts?).

What would be the best way to test the feature?

This are the data:

Could I throw this into the service as it is?

@mapmeld
Copy link
Owner

mapmeld commented Mar 28, 2018

Hi, what happens when you try to load http://mapmeld.com/iD/ ? Is it possibly an issue where your browser is wanting to redirect to HTTPS? I was able to load it on my computer just now, and I hadn't tried accessing it before from this machine

@jgravois
Copy link
Collaborator

hi @tordans!

api06.dev.openstreetmap.org (from openstreetmap#4633 (comment)) does not let me log in

you'll need to create a separate dedicated dev account to login to dev.openstreetmap.org

An example API response would be https://trees.codefor.de/api/trees/?tile=15/17602/10749
Could I throw this into the service as it is?

right now our branch only knows how to fetch GeoJSON from web services that follow the Geoservices spec.

@tordans
Copy link
Author

tordans commented Mar 29, 2018

Hi, what happens when you try to load http://mapmeld.com/iD/ ?

@mapmeld it might be, that my Browser is German and the de.json is missing? Can I force-load the english editor (I could not find an option in Chrome or Firefox).

request.js:117 GET http://mapmeld.com/iD/locales/de.json 404 (Not Found)
send @ request.js:117
get @ request.js:97
(anonymous) @ type.js:8
context.loadLocale @ context.js:393
ui @ init.js:347
(anonymous) @ (index):49
3/iD/#background=Bing&disable_features=boundaries:1 Unchecked runtime.lastError: The message port closed before a response was received.

bildschirmfoto 2018-03-29 um 07 46 39


api06.dev.openstreetmap.org (from openstreetmap#4633 (comment)) does not let me log in
you'll need to create a separate dedicated dev account to login to dev.openstreetmap.org

Thanks @jgravois with a fresh account from dev.… I can log in. However, I don't see any edit-notes/-pathes but get an Error Unchecked runtime.lastError: The message port closed before a response was received. in the console. Also random server 500-errors in between.


right now our branch only knows how to fetch GeoJSON

Update: @jgravois IMO https://trees.codefor.de/api/trees/?tile=15/17602/10749 follows the GeoJSON standard already, but it wraps the GeoJSON result in features array. So this additional wrapper needs to be gone in order for it to work, correct? (The top level object of the API result needs to be in the GeoJSON-format.)
Update2: So https://trees.codefor.de/api/trees/1 should work already?

@jgravois
Copy link
Collaborator

jgravois commented Mar 29, 2018

IMO trees.codefor.de/api/trees/?tile=15/17602/10749 follows the GeoJSON standard already

So trees.codefor.de/api/trees/1 should work already?

Our branch currently constructs request parameters to fetch GeoJSON in a very particular way (acccording to a specification popularized by Esri called Geoservices).

In the longer term plan we'd certainly be interested in refactoring the code so that you could point it at any old GeoJSON (as long as its appropriately licensed 😉) but right now your own service would need to listen and respond to a request like this:

${your url}/query?
where=1=1&
returnCountOnly=false&
geometry={"xmin":-77.025008,"ymin":38.900257,"xmax":-77.006936,"ymax":38.912242,"spatialReference":{"wkid":4326}}&
geometryType=esriGeometryEnvelope&
spatialRel=esriSpatialRelIntersects&
inSR=4326&
f=geojson

@mapmeld
Copy link
Owner

mapmeld commented Apr 10, 2018

@tordans I've fixed the locales issue

@tordans
Copy link
Author

tordans commented Apr 10, 2018

@mapmeld yes, it is fixed, thanks.

Now I need to figure out how to make the request-URL match the specs :).

PS: The GIF at openstreetmap#4633 (comment) helps to find the button that opens the importer-url-dialogue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants