Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mandatory, user editable discussion tag to changeset #45

Merged
merged 1 commit into from
Aug 9, 2017
Merged

add mandatory, user editable discussion tag to changeset #45

merged 1 commit into from
Aug 9, 2017

Conversation

jgravois
Copy link
Collaborator

@jgravois jgravois commented Aug 9, 2017

i noticed today that ;Geoservice was no longer being appended to the imagery_used changeset tag. i think that regression is the result of #29

this PR:

  • handles the above (i'm just skipping the gsLayer.enabled() check, happy to discuss other options)
  • adds a new non-editable source tag and automatically inserts the layer url
  • adds a new mandatory, editable import_discussion tag

the last two are based on the feedback here openstreetmap#4164 (comment)

@mapmeld mapmeld merged commit 6a6ad18 into mapmeld:geoservices Aug 9, 2017
@jgravois jgravois deleted the import_discussion branch August 9, 2017 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants