Add text-offset and shield-offset #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3.0.20/reference.json
Outdated
| "expression": true, | ||
| "default-value": 0.0, | ||
| "default-meaning": "Will not be offset.", | ||
| "doc": "Offsets a line or a polygon a number of pixels parallel to its actual path. Positive values move the line left, negative values move it right (relative to the directionality of the line).", |
There was a problem hiding this comment.
Offsets a line or a polygon
Aren't we talking about a shield instead?
There was a problem hiding this comment.
Good point. It offsets underlaying geometry, which causes texts or shields to move by the offset in case of placement="line", but not in the case of placement="grid". In such case it reduces or expands underlaying polygon area where individual placements can go. I will try to describe it better.
3.0.20/reference.json
Outdated
| "expression": true, | ||
| "default-value": 0.0, | ||
| "default-meaning": "Will not be offset.", | ||
| "doc": "Offsets a line or a polygon a number of pixels parallel to its actual path. Positive values move the line left, negative values move it right (relative to the directionality of the line).", |
|
@yohanboniface I've tried to improve the description. |
yohanboniface
approved these changes
Aug 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced in mapnik/mapnik#3847, released in Mapnik 3.0.19.
@kocio-pl