-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add text-offset and shield-offset #151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments :)
3.0.20/reference.json
Outdated
"expression": true, | ||
"default-value": 0.0, | ||
"default-meaning": "Will not be offset.", | ||
"doc": "Offsets a line or a polygon a number of pixels parallel to its actual path. Positive values move the line left, negative values move it right (relative to the directionality of the line).", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Offsets a line or a polygon
Aren't we talking about a shield instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. It offsets underlaying geometry, which causes texts or shields to move by the offset in case of placement="line"
, but not in the case of placement="grid"
. In such case it reduces or expands underlaying polygon area where individual placements can go. I will try to describe it better.
3.0.20/reference.json
Outdated
"expression": true, | ||
"default-value": 0.0, | ||
"default-meaning": "Will not be offset.", | ||
"doc": "Offsets a line or a polygon a number of pixels parallel to its actual path. Positive values move the line left, negative values move it right (relative to the directionality of the line).", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here :)
@yohanboniface I've tried to improve the description. |
Introduced in mapnik/mapnik#3847, released in Mapnik 3.0.19.
@kocio-pl