postgis: avoid potential crash if connection is not initialized

mapnik · Apr 2, 2013 · c6fd387 · c6fd387
1 parent 42d7263
commit c6fd387
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/plugins/input/postgis/connection.hpp b/plugins/input/postgis/connection.hpp
@@ -53,7 +53,7 @@ class Connection
         {
             std::ostringstream s;
             s << "Postgis Plugin: ";
-            if (conn_ )
+            if (conn_)
             {
                 std::string msg = PQerrorMessage(conn_);
                 if (! msg.empty())
@@ -64,14 +64,13 @@ class Connection
                 {
                     s << "unable to connect to postgres server";
                 }
+                PQfinish(conn_);
             }
             else
             {
                 s << "unable to connect to postgres server";
             }
             s << "\n" << connection_str;
-
-            PQfinish(conn_);
             throw mapnik::datasource_exception(s.str());
         }
     }