New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimizing xml loading (spirit grammars) #1028
Comments
… (TODO - still need to handle text/shield expressions)
next step (before this can be closed) is to figure out how to pass grammars to the |
Perhaps we could create a new data structure to handle xml processing. It could store the grammar with correct encoding settings. This data structure could be passed to all function calls and it would be easier to expose it in python. See also #1041. |
@herm - that sounds good to me. |
A surprising amount of
load_map()
time/calls are spent withcolor_factory::init_from_string()
(and expression::compile()).The reason is that the grammars a being created per parse. We need to create the grammars once. We could create them globally (and perhaps leverage boost::thread_specific_ptr) but in this case it is easy to make them members of the
map_parser
.The grammar getting created/destroyed (I think):
The text was updated successfully, but these errors were encountered: