Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests for handling of value_null in each datasource #1644

Closed
springmeyer opened this issue Dec 12, 2012 · 2 comments
Closed

tests for handling of value_null in each datasource #1644

springmeyer opened this issue Dec 12, 2012 · 2 comments
Labels
mustfix
Milestone
Mapnik 2.2

Comments

@springmeyer
Copy link
Member

When the postgis tests are done, I will close mapbox/carto#75

Followup to #1642 and #794
@springmeyer
Copy link
Member Author

also need to review entire behavior after 562fada#include/mapnik/feature.hpp, in that we may no longer need to return actual value_null() instance from datasource plugins.

springmeyer pushed a commit that referenced this issue Apr 11, 2013
add null and boolean comparison test for postgis - refs #794, #1642, #…
6691267 
…1644
@springmeyer springmeyer mentioned this issue Apr 11, 2013
Closed
@springmeyer
Copy link
Member Author

confirmed that for postgres we do not need to store null values. storing nulls is equivalent to accessing attributes that do not exist in the feature, but saves space. The only other plugins that started storing nulls were sqlite and shape and they should behave the same.

springmeyer pushed a commit that referenced this issue Apr 11, 2013
plugins do not need to store nulls / save space - refs #1644
9da1f35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mustfix
Projects
None yet
Milestone
Mapnik 2.2
Development

No branches or pull requests
1 participant
@springmeyer