Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[input.postgis] persist_connection:true may result in termination due to uncought exception #2191

Closed
strk opened this issue Mar 26, 2014 · 5 comments · Fixed by #2194
Closed

[input.postgis] persist_connection:true may result in termination due to uncought exception #2191

strk opened this issue Mar 26, 2014 · 5 comments · Fixed by #2194
Milestone
Mapnik 2.3.0

Comments

@strk
Copy link
Contributor

strk commented Mar 26, 2014

When the backend is shut down, postgis_datasource destructor will fail to borrow a connection object from the pool which would throw an exception.
Throwing an exception from a destructor results in termination abort.
@strk
Copy link
Contributor Author

strk commented Mar 26, 2014

See also #2190

strk pushed a commit to strk/mapnik that referenced this issue Mar 26, 2014
Do not throw in postgis_datasource destruction if backend is down
189d86d 
... and persist_connections is true!
Closes mapnik#2191
@strk strk mentioned this issue Mar 26, 2014
Merged
strk pushed a commit to strk/mapnik that referenced this issue Mar 26, 2014
Do not throw in postgis_datasource destruction if backend is down
9d04d9f 
... and persist_connections is true!
Closes mapnik#2191
@strk strk mentioned this issue Mar 26, 2014
Merged
@strk
Copy link
Contributor Author

strk commented Mar 26, 2014

Pull request for 2.2.x: #2192
Pull request for 2.3.x: #2193

I hadn't produced a pull request for master.
Hopefully master would do this thing differently but otherwise, and maybe anyway, it would be a cherry-pick away.

\cc @springmeyer

strk pushed a commit to strk/mapnik that referenced this issue Mar 26, 2014
Do not throw in postgis_datasource destruction if backend is down
3268043 
... and persist_connections is true!
Closes mapnik#2191
@strk strk mentioned this issue Mar 26, 2014
Merged
@strk
Copy link
Contributor Author

strk commented Mar 26, 2014

I finally also sent a pull request for master: #2194

@strk
Copy link
Contributor Author

strk commented Apr 4, 2014

ping: this is a crash-prevention fix \cc @springmeyer

@springmeyer
Copy link
Member

Thanks @strk. Traveling today but will merge asap.

On Apr 4, 2014, at 2:24 AM, strk notifications@github.com wrote:

ping: this is a crash-prevention fix \cc @springmeyer

—
Reply to this email directly or view it on GitHub.

@springmeyer springmeyer added this to the Mapnik 2.3.0 milestone Apr 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Mapnik 2.3.0
Development

Successfully merging a pull request may close this issue.

Do not throw in postgis_datasource destruction if backend is down strk/mapnik
2 participants
@springmeyer @strk