Valid geojson geometry fails to parse

[springmeyer]

This parses (as it should):

>>> mapnik.Path.from_geojson('{"type":"Point","coordinates":[-92.22568,38.59553]}').to_geojson()
'{"type":"Point","coordinates":[-92.22568,38.59553]}'

But this does not:

>>> mapnik.Path.from_geojson('{"coordinates":[-92.22568,38.59553],"type":"Point"}')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
RuntimeError: Failed to parse geojson geometry

[artemp]

@springmeyer - yes, our geojson parser expects "type" before "coordinates" as it's greedy parser.
To fix this we need to a generic data structure to parse various "coordinates" versions first and then extract correct geometry representation based on "type". This will result in an extra memory allocation I was trying to avoid but looks like we need to handle it. On my TODO list.

[sgillies]

I'm late to the party here, but it's possible that my recent commit mapbox/mapnik-omnivore#17 might introduce Mapnik to more key-sorted GeoJSON (coordinates/geometry/features before type).

[springmeyer]

Thanks for the heads up @sgillies - for now we should be safe because mapnik-omnivore currently uses OGR still to read GeoJSON files. Once this is fixed in Mapnik however we'll be safe to switch to this native approach (the goal being faster i/o than through OGR).

[artemp]

fixed in 3c99514

[springmeyer]

re-opening since this needs backported to 2.3.x.

[springmeyer]

Assigning to 3.x until we determine its worth backporting.

[springmeyer]

closing, we now have tests in master, let's just run this out in 3.x for now.