New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression: projections need to be a crs #4306
Comments
According to OSGeo/PROJ#3161 (comment) that string cannot be turned into a crs, so no. |
Hi @artemp, I wanted to ask what your plans are. Do you plan to add another codepath that also supports projections that are not a crs? Or do you plan to drop support for non-crs projections with the next release? Thanks! |
Just to note: with #4305 minimum proj version is bumpt up to 8.0.0 from 7.2.0
@artemp this was detected with the docker image PR #4267 since it is using ubuntu 21.04. The new ubuntu LTS 22.04 has currently 8.2.1 (https://packages.ubuntu.com/search?suite=default§ion=all&arch=any&keywords=libproj-dev&searchon=names) |
@mathisloge I think we should use |
@josch I'm trying to figure out if this is something we can support. It would be super useful to see |
I filed #4307 to fix this.
I'm afraid I'm a complete proj noob. That's why I asked how to do it in OSGeo/PROJ#3161 (comment) but as the issue is closed I don't expect a reply. I also asked the more general question on stackoverflow https://stackoverflow.com/questions/71823105 because all code I've seen so far that migrates to more recent proj versions just uses Since this is breaking my use-case for mapnik I'm willing to submit a pull request with an alternative code-path for non-crs input projections but first I have to learn how to do it in the first place. :( |
Hi,
thanks a lot for implementing proj7 support in 88241b3. Unfortunately, that commit introduces a call to
proj_create_crs_to_crs
which means that projections must now be a crs. I was using this pipeline before:and that doesn't work anymore as
proj_create_crs_to_crs
will fail with(It took me a while to figure out where the error comes from, so I also filed #4305 to improve error reporting)
Is this change intentional and do projections need to be a crs from now on? Projections that were not a crs worked fine in the past.
The text was updated successfully, but these errors were encountered: