GCC 14 build errors

[hummeltech]

/mapnik/include/mapnik/grid/grid_view.hpp:109:20: error: no match for ‘operator=’ (operand types are ‘const std::string’ {aka ‘const std::__cxx11::basic_string<char>’} and ‘const std::string’ {aka ‘const std::__cxx11::basic_string<char>’})
  109 |         key_ = rhs.key_;
      |                    ^~~~

/mapnik/include/mapnik/grid/grid_view.hpp:110:24: error: no match for ‘operator=’ (operand types are ‘const std::string’ {aka ‘const std::__cxx11::basic_string<char>’} and ‘const std::string’ {aka ‘const std::__cxx11::basic_string<char>’})
  110 |         id_name_ = rhs.id_name_;
      |                        ^~~~~~~~

/mapnik/include/mapnik/grid/grid_view.hpp:111:22: error: no match for ‘operator=’ (operand types are ‘const std::set<std::__cxx11::basic_string<char> >’ and ‘const std::set<std::__cxx11::basic_string<char> >’)
  111 |         names_ = rhs.names_;
      |                      ^~~~~~

/mapnik/include/mapnik/grid/grid_view.hpp:113:25: error: no match for ‘operator=’ (operand types are ‘const mapnik::hit_grid_view<T>::feature_type’ {aka ‘const std::map<std::__cxx11::basic_string<char>, std::shared_ptr<mapnik::feature_impl> >’} and ‘const mapnik::hit_grid_view<T>::feature_type’ {aka ‘const std::map<std::__cxx11::basic_string<char>, std::shared_ptr<mapnik::feature_impl> >’})
  113 |         features_ = rhs.features_;
      |                         ^~~~~~~~~

https://gcc.gnu.org/gcc-14/changes.html

mapnik/include/mapnik/grid/grid_view.hpp

Lines 100 to 115 in 4114824

	hit_grid_view<T>& operator=(hit_grid_view<T> const& rhs)
	{
	if (&rhs == this)
	return *this;
	x_ = rhs.x_;
	y_ = rhs.y_;
	width_ = rhs.width_;
	height_ = rhs.height_;
	data_ = rhs.data_;
	key_ = rhs.key_;
	id_name_ = rhs.id_name_;
	names_ = rhs.names_;
	f_keys_ = rhs.f_keys_;
	features_ = rhs.features_;
	return *this;
	}

[tomhughes]

This will be an assignment operator that is never used, and was never actually usable, but is now reported even though it is never actually used.

[hummeltech]

Thank you for the clarification, I had a feeling it might not be in use.

[artemp]

@hummeltech @tomhughes

How about

hit_grid_view<T>& operator=(hit_grid_view<T> const& rhs) = delete;

I don't think we need a copy assignment operator for grid_view

[hummeltech]

@artemp, thanks for the help, the commit 653d8b7 does indeed resolve the issue mentioned in the description!