Cairo PDF output misplaces shield of ShieldSymbolizer

[artemp]

Today I upgraded the main OSM tile server to Mapnik2 SVN trunk and the road shields are now being placed incorrectly in the Cairo PDF output (from the /export tab). The PNG output looks fine.

The machine is running with the latest versions of the Cairo chain:

• cairo-1.10.2
• cairomm-1.9.8
• pixman-0.21.6

[artemp]

[Ldp] The cairo chain places the shield origin at the text center, instead of moved half width/height to the left/top. This patch is the most notable difference between the cairo and agg chains.

[artemp]

[Ldp] Patch applied in r2652

[artemp]

[rcoup] @Ldp also brought up:
[11:23] <Ldp__> what about the missing floor() on x,y a few lines earlier?
[11:23] <Ldp__> should we synch that to agg as well?
[11:24] <rcoup> Ldp__: which lines?
[11:24] <rcoup> (the missing floor())
[11:24] <Ldp__> http://trac.mapnik.org/browser/trunk/src/agg/process_shield_symbolizer.cpp#L220
[11:25] <Ldp__> vs http://trac.mapnik.org/browser/trunk/src/cairo_renderer.cpp#L1251

Will keep this open until @tcollett has a chance to review.

[springmeyer]

@rcoup - can this be closed now? /cc @thjc

[springmeyer]

assuming this can be closed, so closing it. In master (upcoming 2.1.x release) there has been much refactoring so if this persists it will be re-addressed separately.