-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sqlite.input refactoring #928
Comments
i'm for this:
and, be careful when using rowid (i would avoid it like tha plague), that will lead to wrong results every time you manipulate your table (aka insert/delete). we should rely on PK only, as that ensure the rtree is always consistent. |
…al sqlite refactoring fixes refs #928
@kunitoki - Yes, I'm actively working on avoiding rowid hardcoding (now that we can autodetect primary key via I'm also in favor of fastest possible initialization if no user-defined parameters are passed, but when they are passed then skipping lookups wherever possible. I'm also actively thinking about making some requirements, like extent, able to be more lazily evaluated. |
sqlite-refactor branch now merged, closing. indexing functionality has been abstracted out, but auto-indexing is still in place. plan to move this to an api call - that work is underway into |
…al sqlite refactoring fixes refs mapnik#928
I'm moving large chunks of logic out of bind() and looking at removing auto-indexing to just be an api call that a developer would need to use (not triggered on load). This is all helpful to to ensure correctness of the key_field handling because the size of the code makes following the logic hard. Will work on this tomorrow.
The text was updated successfully, but these errors were encountered: