Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlite.input refactoring #928

Closed
springmeyer opened this issue Oct 24, 2011 · 3 comments · Fixed by #943
Closed

sqlite.input refactoring #928

springmeyer opened this issue Oct 24, 2011 · 3 comments · Fixed by #943
Assignees
Milestone

Comments

@springmeyer
Copy link
Member

I'm moving large chunks of logic out of bind() and looking at removing auto-indexing to just be an api call that a developer would need to use (not triggered on load). This is all helpful to to ensure correctness of the key_field handling because the size of the code makes following the logic hard. Will work on this tomorrow.

@ghost ghost assigned springmeyer Oct 24, 2011
@kunitoki
Copy link
Member

i'm for this:

  • favour user defined parameters and avoid doing any metadata calls if don't needed
  • for every user unspecified parameter, collect and prepare the fastest way to query all of the remaining data in a single batch

and, be careful when using rowid (i would avoid it like tha plague), that will lead to wrong results every time you manipulate your table (aka insert/delete). we should rely on PK only, as that ensure the rtree is always consistent.

springmeyer pushed a commit that referenced this issue Oct 25, 2011
@springmeyer
Copy link
Member Author

@kunitoki - Yes, I'm actively working on avoiding rowid hardcoding (now that we can autodetect primary key via table_info) - making good progress, thanks for the suggestion.

I'm also in favor of fastest possible initialization if no user-defined parameters are passed, but when they are passed then skipping lookups wherever possible.

I'm also actively thinking about making some requirements, like extent, able to be more lazily evaluated.

@springmeyer
Copy link
Member Author

sqlite-refactor branch now merged, closing. indexing functionality has been abstracted out, but auto-indexing is still in place. plan to move this to an api call - that work is underway into indexing-api branch.

kkaefer pushed a commit to kkaefer/mapnik that referenced this issue Feb 16, 2012
kkaefer pushed a commit to kkaefer/mapnik that referenced this issue Feb 16, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants