SVG parser refactoring and improvements #3003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lect error messages
SVG spec : ".. If 'rx' is greater than half of the width of the rectangle, then the user agent must process the 'rect' element with the effective value for 'rx' as half of the width of the rectangle. If 'ry' is greater than half of the height of the rectangle, then the user agent must process the 'rect' element with the effective value for 'ry' as half of the height of the rectangle.."
| { | ||
| for (auto const& msg : p.error_messages()) | ||
| { | ||
| std::cerr << "SVG PARSING ERROR:\"" << msg << "\"" << std::endl; |
There was a problem hiding this comment.
@jakepruitt - yes, fixed in 3a4d574. I also made marker_cache to return marker_null() if case of any parsing/values errors. I think this is desired logic : only accept SVG we can interpret correctly and fail otherwise + logging errors.
| REQUIRE(y1 == 25); | ||
| REQUIRE(x2 == 10); | ||
| REQUIRE(y2 == 10); | ||
| REQUIRE(r == 75); |
There was a problem hiding this comment.
Question, @artemp. The gradient fixture for this test has the following format
<radialGradient id="grad1b" gradientUnits="userSpaceOnUse" cx="10%" cy="10%" r="75%" fx="00.00%" fy="25%">
This translates to the above values when get_control_points is called. Is this the expected value? Should the values be 0, 0.25, 0.10, 0.10, 0.75 respectively due to the percentage conversion?
There was a problem hiding this comment.
@jakepruitt - great catch! this was a bug in grammar - fixed in 42bf230
Summary of main changes
|
artemp
added a commit
that referenced
this pull request
Jul 31, 2015
SVG parser refactoring and improvements
This was referenced Jul 31, 2015
cjmayo
added a commit
to cjmayo/mapnik
that referenced
this pull request
May 5, 2020
Change to RapidXml made in: mapnik#3003
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ptree(rapidxml inside boost::property_tree) as default xml parserFollowups: