Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New interior for v3.0.x #3840

Merged
merged 6 commits into from Jan 24, 2018
Merged

New interior for v3.0.x #3840

merged 6 commits into from Jan 24, 2018

Conversation

talaj
Copy link
Member

@talaj talaj commented Jan 24, 2018

Addresses #3839.

* visual tests: refactor parsing parameters from the style

* visual tests: allow to ignore particular renderer

* update visual tests
@codecov
Copy link

codecov bot commented Jan 24, 2018

Codecov Report

Merging #3840 into v3.0.x will increase coverage by 6.94%.
The diff coverage is 96.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           v3.0.x    #3840      +/-   ##
==========================================
+ Coverage   58.34%   65.28%   +6.94%     
==========================================
  Files         435      443       +8     
  Lines       21654    21813     +159     
  Branches     3200        0    -3200     
==========================================
+ Hits        12634    14241    +1607     
+ Misses       7607     7572      -35     
+ Partials     1413        0    -1413
Impacted Files Coverage Δ
include/mapnik/markers_placements/basic.hpp 100% <ø> (ø) ⬆️
include/mapnik/geom_util.hpp 87.5% <ø> (+87.5%) ⬆️
...apnik/renderer_common/process_point_symbolizer.hpp 88.09% <0%> (+13.09%) ⬆️
src/text/symbolizer_helpers.cpp 95.93% <100%> (+11.64%) ⬆️
...clude/mapnik/geometry/polygon_vertex_processor.hpp 100% <100%> (ø)
src/renderer_common/render_markers_symbolizer.cpp 96.29% <100%> (+8.44%) ⬆️
include/mapnik/markers_placements/interior.hpp 78.26% <100%> (+37.08%) ⬆️
src/geometry/interior.cpp 96.1% <96.1%> (ø)
include/mapnik/raster_colorizer.hpp 85.71% <0%> (-14.29%) ⬇️
include/mapnik/text/scrptrun.hpp 90% <0%> (-4.74%) ⬇️
... and 195 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 497b516...cfd9668. Read the comment docs.

@artemp
Copy link
Member

artemp commented Jan 24, 2018

Thanks @talaj !

@artemp artemp merged commit 3c2d657 into mapnik:v3.0.x Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants